[OpenJDK 2D-Dev] <AWT Dev> RFR: Allow using the system libjpeg

[Andrew Hughes]

----- Original Message -----
> Hi,
> 
> Updated webrevs:
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01/
> http://cr.openjdk.java.net/~omajid/webrevs/system-libjpeg/01.jdk/
> 
> * Anthony Petrov <anthony.petrov at oracle.com> [2014-05-19 14:42]:
> > make/lib/Awt2dLibraries.gmk
> > >1236     LIBJPEG_CFLAGS :=
> > >$(JDK_TOPDIR)/src/share/native/sun/awt/image/jpeg
> > 
> > Since these are compiler flags, I suppose this should read "-I<path>", not
> > just "<path>".
> 
> Yes, it should. I wonder how my compiler accepted that.
> 
> > Did you build with --with-jpeg=bundled ? Can the resulting JDK read jpeg
> > files?
> 
> I did. I tested both combinations and made sure both the splash screen
> and javax.swing.ImageIcon could display jpegs files with the first
> webrev I posted.
> 
> Thanks,
> Omair
> 
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

I'm not keen on the hardcoding of '-ljpeg'

+  LIBJPEG_LIBS := -ljpeg

Could this not at least be conditionally assigned? (?=)
-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07