RFR(S): 8044363: Remove special build options for unpack200 executable

Mikael Vidstedt mikael.vidstedt at oracle.com
Thu May 29 20:29:34 UTC 2014


Please review the below fix which removes a couple of build options used 
when compiling/linking the unpack200 executable - specifically 
-xregs=no%appl and -xmemalign=4s.

Bug: https://bugs.openjdk.java.net/browse/JDK-8044363
Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8044363/webrev.00/webrev/

Discussion:

The -xregs=no%appl is supposed to be used when compiling system 
libraries [1], but unpack200 is an executable and so does not fall in 
that category. The -memalign=4s is supposed to help porting code [2] by 
having the compiler generate code which does not assume full natural 
data alignment, but the code in question is clean and does not require 
this option.

Testing:

Kumar graciously helped me test the change by manually packing/unpacking 
across different platforms. I'm taking suggestions on any further 
testing needed.

Thanks,
Mikael

[1] http://docs.oracle.com/cd/E19205-01/819-5265/bjawv/index.html
[2] http://docs.oracle.com/cd/E19205-01/819-5265/bjavc/index.html



More information about the build-dev mailing list