RFR(S): 8044363: Remove special build options for unpack200 executable

[Mikael Vidstedt]

Kumar - Thanks for the review and the help testing this!

Cheers,
Mikael

On 2014-05-29 18:05, Kumar Srinivasan wrote:
>
>> Looks good. The JBS bug needs noreg-build
>>
>> Thanks
>> Kumar
>>
>>
>> On 5/29/2014 1:29 PM, Mikael Vidstedt wrote:
>>>
>>> Please review the below fix which removes a couple of build options 
>>> used when compiling/linking the unpack200 executable - specifically 
>>> -xregs=no%appl and -xmemalign=4s.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8044363
>>> Webrev: 
>>> http://cr.openjdk.java.net/~mikael/webrevs/8044363/webrev.00/webrev/
>>>
>>> Discussion:
>>>
>>> The -xregs=no%appl is supposed to be used when compiling system 
>>> libraries [1], but unpack200 is an executable and so 
>
> I missed making this comment in my earlier response. Sorry.
>
> For the record,  the unpacker sources are also compiled as a library  
> (libunpack.so),  I have
> tested both the executable as well as the library version, and they 
> seem to be working
> correctly.
>
>
> Kumar
>
>>> does not fall in that category. The -memalign=4s is supposed to help 
>>> porting code [2] by having the compiler generate code which does not 
>>> assume full natural data alignment, but the code in question is 
>>> clean and does not require this option.
>>>
>>> Testing:
>>>
>>> Kumar graciously helped me test the change by manually 
>>> packing/unpacking across different platforms. I'm taking suggestions 
>>> on any further testing needed.
>>>
>>> Thanks,
>>> Mikael
>>>
>>> [1] http://docs.oracle.com/cd/E19205-01/819-5265/bjawv/index.html
>>> [2] http://docs.oracle.com/cd/E19205-01/819-5265/bjavc/index.html
>>
>