RFR: JDK-8065911 Introduce EvalDebugWrapper for all Setup* macros

[Erik Joelsson]

Looks good.

/Erik

On 2014-11-25 20:19, Magnus Ihse Bursie wrote:
>
> On 2014-11-25 18:57, Erik Joelsson wrote:
>> In ZipArchive.gmk, the file starts with comments referring to sjavac 
>> that look like they were copied from JavaCompilation.gmk.
> Which is exactly what is was. :-)
>>
>> Otherwise looks good. I still haven't tried EvalDebugWrapper but it 
>> looks really neat.
>
> Thanks.
>
> Updated webrev with fixes for ZipArchive:
> http://cr.openjdk.java.net/~ihse/JDK-8065911-evalwrapper/webrev.02
>
> /Magnus
>
>>
>> /Erik
>>
>> On 2014-11-25 16:13, Magnus Ihse Bursie wrote:
>>> We should generalize the use of EvalDebugWrapper to all our SetupFoo 
>>> functions. This will allow better debug possibilities of the build 
>>> system. It will also, as a side effect, allow us to use proper 
>>> whitespace around the parameters when calling this function.
>>>
>>> I also broke out the SetupZipArchive into a separate file. It is 
>>> still included by SetupJavaCompilation, since it is required when 
>>> doing a source zip, so no other changes are needed. Future cleanup 
>>> will allow us to include ZipArchive only instead of JavaCompilation 
>>> if we just want to create a zip file.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8065911
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8065911-evalwrapper/webrev.01
>>>
>>> /Magnus
>>
>