Can not get codes by get_source.sh at Japanese environment.

[bitter_fox]

Hi, Yuji,
I think already this issue was fixed by following commit.

http://hg.openjdk.java.net/jdk9/dev/rev/d9edec389373

Doesn't this one work well?


2014-10-02 9:29 GMT+09:00 Yuji Kubota <jarkeys at gmail.com>:

> Hi Martijin,
>
> Thank you for your reply, and sorry my mistake.
> My patch is here.
>
> ----------
> diff -r 0958d0a9f44e get_source.sh
> --- a/get_source.sh     Wed Oct 01 07:45:02 2014 -0700
> +++ b/get_source.sh     Wed Oct 01 16:56:33 2014 -0700
> @@ -67,7 +67,7 @@
>    error "Could not locate Mercurial command"
>  fi
>
> -hgversion="`hg --version 2> /dev/null | sed -n -e 's@^Mercurial
> Distributed SCM (version \([^+]*\).*)\$@\1 at p'`"
> +hgversion="`LANG=en hg --version 2> /dev/null | sed -n -e
> 's@^Mercurial Distributed SCM (version \([^+]*\).*)\$@\1 at p'`"
>  if [ "x${hgversion}" = "x" ] ; then
>    error "Could not determine Mercurial version of $hgwhere"
>  fi
> ----------
>
> In addition to this, I change the code which based on all *.po files
> of mercurial.
> -------
> hgversion="`hg --version 2> /dev/null | head -n 1 | sed -n -e 's@^.*
> \([0-9\.]\+\).*)\$@\1 at p'`"
> -------
>
> Please check it.
>
> Cheers,
> KUBOTA Yuji
>
> 2014-10-01 17:02 GMT-07:00 Martijn Verburg <martijnverburg at gmail.com>:
> > Hi Yuji,
> >
> > Martijn here (we met at Hackergarden).  The OpeJDK mailing lists don't
> > accept attachments, are you able to copy the content of the patch (diff)
> and
> > post in the body of the message?
> >
> > Cheers,
> > Martijn
> >
> > On 1 October 2014 16:59, Yuji Kubota <jarkeys at gmail.com> wrote:
> >>
> >> Hi all,
> >> I wrote this report and patch at Hackergarten in JavaOne2014.
> >>
> >> When I try to get source codes of jdk8 in Japanese environment,
> >> get_source.sh can not parse the "hg -version" correctly.
> >> So I can not get the source codes, because the result of "hg -version"
> >> has japanese charcthers.
> >>
> >> Mercurial use *.po files for i18n, so I set required LANGUAGE before
> >> call hg commands.
> >> Please review attached patch! :)
> >>
> >> And thank hackergarten for many advices!
> >> ---
> >> KUBOTA Yuji
> >
> >
>