GNU Make 4.0

[Salter, Thomas A]

I'm building 8u5.  I think that was the first update after JDK 8 shipped.

Do you remember the nature of the subtle differences?  This problem could very well be the result of my changes to some of the make files.

Tom


-----Original Message-----
From: Erik Joelsson [mailto:erik.joelsson at oracle.com] 
Sent: Monday, October 13, 2014 5:05 AM
To: Salter, Thomas A
Cc: Omair Majid; OpenJDK (build-dev at openjdk.java.net)
Subject: Re: GNU Make 4.0

Hello,

The patch from Omair will likely be needed for building hotspot. Your 
failure is much earlier though. There are some subtle differences in 
make 3.82 and 4.0 regarding escaping of $ in certain situations. This 
caused some trouble with referring to inner classes from makefiles. I 
did some improvements in this area at some point but don't remember 
exactly when. When you say not up to date, how old is that? I'm pretty 
sure that jdk8 at release was buildable with make 4.0, but I may be wrong.

/Erik

On 2014-10-10 21:39, Omair Majid wrote:
> * Salter, Thomas A <Thomas.Salter at unisys.com> [2014-10-10 14:23]:
>> Are there any known issues with using GNU Make 4.0 to build OpenJDK8?
> Yes. I had to add this patch in Fedora to build with Make 4.0:
> http://pkgs.fedoraproject.org/cgit/java-1.8.0-openjdk.git/tree/hotspot-build-j-directive.patch
>
> Cheers,
> Omair
>