RFR: 8056209 : Remove unused files for libawt

Phil Race philip.race at oracle.com
Fri Sep 5 15:59:46 UTC 2014


 > Actually, we need to update the makefiles as well, since these are 
listed as exceptions.

Gosh ... I should have remembered that to begin with.

Here's the fixed patch http://cr.openjdk.java.net/~prr/8056209.1

-phil

On 09/05/2014 03:01 AM, Magnus Ihse Bursie wrote:
> On 2014-09-04 23:48, Phil Race wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8056209
>> Proposed removing several files
>> ./windows/native/libawt/sun/java2d/d3d/D3DPipeline.cpp
>>   ./windows/native/libawt/sun/java2d/d3d/D3DShaderGen.c
>>   ./windows/native/libawt/sun/windows/WBufferStrategy.cpp
>>
>> After some analysis the actual list of files to remove is
>>
>> src/java.desktop/windows/native/libawt/sun/java2d/d3d/D3DPipeline.cpp
>>
>> - this file appears to be unneeded and has never been built
>>
>> src/java.desktop/windows/classes/sun/awt/windows\WBufferStrategy.java
>> src/java.desktop/windows/native/libawt/sun/windows/WBufferStrategy.cpp
>>
>> - both of these files have not been built since 6u10
>>
>> D3DShaderGen.c needs to remain. It perhaps should live somewhere else
>> but it also needs a bit of maintenance. A new bug should be filed on 
>> that
>>
>> here's a webrev for what value it adds :- 
>> http://cr.openjdk.java.net/~prr/8056209/
>
> Actually, we need to update the makefiles as well, since these are 
> listed as exceptions.
>
> diff -r 99da8eb27d0a make/lib/Awt2dLibraries.gmk
> --- a/make/lib/Awt2dLibraries.gmk       Wed Aug 27 10:14:16 2014 +0200
> +++ b/make/lib/Awt2dLibraries.gmk       Fri Sep 05 12:00:45 2014 +0200
> @@ -216,10 +216,8 @@
>        -I$(JDK_OUTPUTDIR)/gensrc_headers/java.base \
>        #
>    LIBAWT_EXFILES += \
> -      sun/java2d/d3d/D3DPipeline.cpp \
>        sun/java2d/d3d/D3DShaderGen.c \
>        sun/awt/image/cvutils/img_colors.c \
> -      sun/windows/WBufferStrategy.cpp \
>        #
>
>    LIBAWT_LANG := C++
>
> Thanks for addressing this Phil!
>
> /Magnus




More information about the build-dev mailing list