RFR: JDK-8056999 Make hotspot builds less verbose on default log level

[David Holmes]

On 16/09/2014 7:37 PM, Magnus Ihse Bursie wrote:
> On 2014-09-16 08:44, David Holmes wrote:
>> Hi Magnus,
>>
>> This seems okay to me.
>
> Thank you. Since this is a hotspot change, I assume I need a second
> reviewer, and that it should be pushed into hs-rt, right?

Right.

>>
>> Just for everyone else's benefit. We can pass LOG=info etc as a
>> configure arg to set the default log level. But we can also pass
>> LOG_LEVEL=XXX as a make arg to override that default.
>
> Actually, you cannot set the default log level in configure in that way.
> :-( But that sounded like a good idea, though. I'll open a bug for it.
> Normally, LOG_LEVEL is considered an internal variable that should not
> be set by the user, but if you want to call the hotspot makefile
> directly, and still benefit from this change, then you need to set
> LOG_LEVEL (instead of LOG). LOG is processed in the top makefile, and
> one of the result of the processing is that LOG_LEVEL is set.

Hmmm. I have been using this technique with apparent success, but only 
to enable more verbose logging - so perhaps it was not working as I was 
thinking.

David

> /Magnus
>>
>> Thanks,
>> David
>>
>> On 15/09/2014 9:16 PM, Magnus Ihse Bursie wrote:
>>> Here is the full review of this fix. I have now applied the same pattern
>>> as I used on linux to aix, bsd and solaris as well.
>>>
>>> It turned out that windows was problematic. Due to the big difference
>>> between windows and the unix versions (different and/or limited nmake
>>> flexibility, different and/or limited shell functionality and
>>> differences in design in the hotspot make files), I did not manage to
>>> get a working Windows version of this fix in a reasonable time frame.
>>> (This fix has already taken more time than I wanted to spend on it.)
>>>
>>> I suggest that this fix nevertheless is an improvment on the other
>>> platforms, and that I open a new bug report for the remaining work on
>>> Windows.
>>>
>>> And here's what I wrote about the preliminary version of this fix:
>>>
>>> Even in the default log level ("warn"), hotspots builds are extremely
>>> verbose. With the new jigsaw build system, hotspot is build in parallel
>>> with the jdk, and the sheer amount of hotspot output makes the jdk
>>> output practically disappear.
>>>
>>> This fix will make the following changes:
>>> * When hotspot is build from the top dir with the default log level, all
>>> repetetive and purely informative output is hidden (e.g. names of files
>>> compiled, and the "INFO:" blobs).
>>> * When hotspot is build from the top dir, with any other log level
>>> (info, debug, trace), all output will be there, as before.
>>> * When hotspot is build from the hotspot repo, all output will be there,
>>> as before.
>>>
>>> I have tested building on JPRT with LOG=debug and LOG=warn, and it all
>>> looks as it should as far as I could tell.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8056999
>>> WebRev:
>>> http://cr.openjdk.java.net/~ihse/JDK-8056999-less-verbose-hotspot-builds/webrev.02
>>>
>>>
>>>
>>> /Magnus
>