RFR: JDK-8055189: Cleanup gensrc after source code restructure
Magnus Ihse Bursie
magnus.ihse.bursie at oracle.com
Wed Sep 17 13:18:19 UTC 2014
On 2014-09-17 14:59, Erik Joelsson wrote:
> Please review this little cleanup patch for Gensrc*.gmk files.
> GensrcProviders.gmk and GensrcJDWP are both short and are only used by
> Gensrc-jdk.jdi.gmk, so I inlined them in that file.
> Gensrc-jdk.attach.gmk was no longer doing anything so it could be
> removed.
>
> I could not find any other simple inline opportunity.
I think you can split up GensrcCharsetMapping.gmk as well, so it only
contains the java.base stuff, and inline the jdk.charsets part directly
into Gensrc-jdk.charsets.gmk.
The changes you already done look good.
/Magnus
More information about the build-dev
mailing list