RFR: 8058756: OpenJDK builds fail on Windows - cannot copy freetype.dll

[pointo1d]

On 19/09/14 08:30, Erik Joelsson wrote:
> I've noticed this problem too but never got around to fix it. The fix 
> is OK, but I would prefer just replacing the CP line with 
> $(install-file), which will also avoid the duplicated source file 
> definition.
>
> /Erik
>
> On 2014-09-18 22:00, Phil Race wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8058756
>>
>> Here's my proposed one-liner fix :-
>>
>> diff -r 07156012ab78 make/copy/Copy-java.desktop.gmk
>> --- a/make/copy/Copy-java.desktop.gmk Thu Sep 18 17:34:44 2014 +0400
>> +++ b/make/copy/Copy-java.desktop.gmk Thu Sep 18 12:51:40 2014 -0700
>> @@ -68,6 +68,7 @@
>>    endif
>>
>>    $(FREETYPE_TARGET_LIB): $(FREETYPE_BUNDLE_LIB_PATH)/$(call 
>> SHARED_LIBRARY,freetype)
>> + $(MKDIR) -p $(JDK_OUTPUTDIR)/bin
>>         $(CP) $(FREETYPE_BUNDLE_LIB_PATH)/$(call 
>> SHARED_LIBRARY,freetype) $@
>>          ifeq ($(OPENJDK_BUILD_OS), windows)
>>           $(CHMOD) +rx $@
>>
>> -phil
>

As a non-reviewer, the fix is good and works but, like Erik, my 
preference would be for the use of ($install-file).

-- 
​Dave Pointon FIAP MBCS - Contractor engaged by IBM

Now I saw, tho' too late, the folly of beginning a work before we count the cost and
before we we judge rightly of our strength to go thro' with it - Robinson Crusoe