RFR: JDK-8058797: Building with sjavac broken after JDK-8058118

[Erik Joelsson]

On 2014-09-19 10:56, David Holmes wrote:
> Hi Erik,
>
> On 19/09/2014 6:45 PM, Erik Joelsson wrote:
>> In JDK-8058118, a small java tool is compiled very early in the make
>> process. This compilation cannot use sjavac since it's done with the
>> boot javac. The fix is simple. Just add DISABLE_SJAVAC := true to the
>> macro call. I also added a comment documenting this already existing
>> feature.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8058797
>> Webrev: http://cr.openjdk.java.net/~erikj/8058797/webrev.root.01/
>
> I'm a bit confused about the comments and code in 
> SetupJavaCompilation. We seem to have a maximum of 16 args; but we've 
> documented 18 possibilities. ???
>
That's a bit peculiar I admit. The reason is that we never use all the 
arguments at once. The maximum number of arguments used in one call is 
simply increased as needed. It's just a technicality in the 
implementation of the named args.

/Erik
> David
>
>> /Erik