JDK 9 RFR of JDK-8077912: Turn on doclint checking for more modules

joe darcy joe.darcy at oracle.com
Thu Apr 16 19:09:29 UTC 2015


PS Some doclint fixes in additional modules came in and Tim did an 
off-list review to add in the new modules to the list.

Thanks,

-Joe

On 4/16/2015 7:46 AM, Tim Bell wrote:
> Joe:
>
>
>> On 2015-04-16 01:50, joe darcy wrote:
>>> Hello,
>>>
>>> Please review the patch below to enable doclint checking on more 
>>> modules in the JDK 9 build:
>>>
>>>     JDK-8077912: Turn on doclint checking for more modules
>>>     http://cr.openjdk.java.net/~darcy/8077912.0/
>>>
>>> (Some doclint cleanup is needed on java.management and 
>>> java.transaction before doclint checking can be enabled in those 
>>> modules.)
>>
>> Looks good to me. I like that warm fuzzy feeling I get when I see all 
>> these cleanups. Thank you :)
>>
>> /Magnus
>
>
> Looks good to me as well.
>
> Tim
>
>>> --- old/make/CompileJavaModules.gmk 2015-04-15 16:45:27.288035401 -0700
>>> +++ new/make/CompileJavaModules.gmk    2015-04-15 16:45:27.216035400 
>>> -0700
>>> @@ -262,6 +262,18 @@
>>>
>>>  ################################################################################ 
>>>
>>>
>>> +java.instrument_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>> +
>>> +################################################################################ 
>>>
>>> +
>>> +java.logging_ADD_JAVAC_FLAGS := -Xdoclint:all/protected,-reference 
>>> '-Xdoclint/package:java.*,javax.*'
>>> +
>>> +################################################################################ 
>>>
>>> +
>>> +java.prefs_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>> +
>>> +################################################################################ 
>>>
>>> +
>>>  java.sql_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>>  java.sql_SETUP := GENERATE_JDKBYTECODE_NOWARNINGS
>>>
>>> @@ -340,6 +352,14 @@
>>>
>>>  ################################################################################ 
>>>
>>>
>>> +java.security.jgss_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>> +
>>> +################################################################################ 
>>>
>>> +
>>> +java.smartcardio.jgss_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>> +
>>> +################################################################################ 
>>>
>>> +
>>>  java.xml.crypto_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
>>> '-Xdoclint/package:java.*,javax.*'
>>>  java.xml.crypto_COPY := .dtd .xml
>>>  java.xml.crypto_CLEAN := .properties
>>>
>>
>




More information about the build-dev mailing list