build failure after switching to vs2013

[Erik Joelsson]

I'm currently working on updating the official compilers used internally 
at Oracle and the intended version for VS is VS2013 sp4. Servicability 
closed the bug David linked, but since the removal of that code hasn't 
happened yet, I think we should propose your patch as a fix for that bug.

/Erik

On 2015-04-22 18:00, David Holmes wrote:
> On 23/04/2015 10:57 AM, Pete Brunet wrote:
>> On 4/22/15 6:48 PM, David Holmes wrote:
>>> Peter,
>>>
>>> See
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8077422
>>>
>>> update 4 is not supported yet.
>> Hi David, Do I need to uninstall Update 4 and install Update 3? -Pete
>
> I was assume so - I have no personal experience with these tools.
>
> David
>
>>>
>>> David
>>>
>>> On 23/04/2015 8:02 AM, Pete Brunet wrote:
>>>> This hack to jdk/make/lib/Lib-jdk.hprof.agent.gmk works for now:
>>>>
>>>>        LANG := C, \
>>>>        OPTIMIZATION := $(LIBHPROF_OPTIMIZATION), \
>>>>        CFLAGS := $(CFLAGS_JDKLIB) $(CFLAGS_WARNINGS_ARE_ERRORS) \
>>>> +        -D_WINSOCK_DEPRECATED_NO_WARNINGS \
>>>>            $(BUILD_LIBHPROF_CFLAGS), \
>>>>        CFLAGS_debug := -DHPROF_LOGGING, \
>>>>        MAPFILE := $(JDK_TOPDIR)/make/mapfiles/libhprof/mapfile-vers, \
>>>>
>>>> Pete
>>>>
>>>> On 4/22/15 4:12 PM, Pete Brunet wrote:
>>>>> p.s. I also had done a make reconfigure and make clean.  I'll try 
>>>>> make
>>>>> clean and reconfigure from bash.
>>>>>
>>>>> On 4/22/15 4:06 PM, Pete Brunet wrote:
>>>>>> I was able to build 9 OK then I switched from VS2010 to VS2013 
>>>>>> and now
>>>>>> get the following.  I tried hg tpull -u but that didn't help.
>>>>>>
>>>>>> Is there something I need to do besides installing VS Pro 2013 with
>>>>>> Update 4?
>>>>>>
>>>>>> $ make images 2>&1 | tee make-64.log
>>>>>> Building target 'images' in configuration
>>>>>> 'windows-x86_64-normal-server-release'
>>>>>>
>>>>>> c:/Users/Pete/JDK9/INTJDK-7615864/client/jdk/src/jdk.hprof.agent/windows/native/libhprof/hprof_md.c(86) 
>>>>>>
>>>>>>
>>>>>> : error C2220: warning treated as error - no 'object' file generated
>>>>>> c:/Users/Pete/JDK9/INTJDK-7615864/client/jdk/src/jdk.hprof.agent/windows/native/libhprof/hprof_md.c(86) 
>>>>>>
>>>>>>
>>>>>> : warning C4996: 'gethostbyname': Use getaddrinfo() or 
>>>>>> GetAddrInfoW()
>>>>>> instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable
>>>>>> deprecated
>>>>>> API warnings
>>>>>> c:\progra~2\wi3cf2~1\8.1\include\um\winsock2.h(2238) : see
>>>>>> declaration of 'gethostbyname'
>>>>>> Lib-jdk.hprof.agent.gmk:44: recipe for target
>>>>>> '/cygdrive/c/Users/Pete/JDK9/INTJDK-7615864/client/build/windows-x86_64-normal-server-release/support/native/jdk.h 
>>>>>>
>>>>>>
>>>>>> prof.agent/libhprof_jvmti/hprof_md.obj' failedmake[3]: ***
>>>>>> [/cygdrive/c/Users/Pete/JDK9/INTJDK-7615864/client/build/windows-x86_64-normal-server-release/support/native/jdk.hprof.agent/libhprof_jvmti/hprof_md.obj] 
>>>>>>
>>>>>>
>>>>>> Error 2
>>>>>> make/Main.gmk:168: recipe for target 'jdk.hprof.agent-libs' failed
>>>>>> make[2]: *** [jdk.hprof.agent-libs] Error 1
>>>>>> make[2]: *** Waiting for unfinished jobs....
>>>>>> /cygdrive/c/Users/Pete/JDK9/INTJDK-7615864/client/make/Init.gmk:255:
>>>>>> recipe for target 'main' failed
>>>>>> make[1]: *** [main] Error 1
>>>>>> /cygdrive/c/Users/Pete/JDK9/INTJDK-7615864/client/make/Init.gmk:171:
>>>>>> recipe for target 'images' failed
>>>>>> make: *** [images] Error 2
>>>>
>>