RFR: JDK-8074016 Add convenient way of adding custom test targets to hotspot's test makefile

David Holmes david.holmes at oracle.com
Tue Apr 28 07:36:19 UTC 2015


+1

At some point we may need a finer-grained include mechanism but for now 
this suffices.

Thanks,
David

On 28/04/2015 3:52 AM, Staffan Larsen wrote:
> Looks good!
>
> Thanks,
> /Staffan
>
>> On 27 apr 2015, at 12:25, Ingemar Aberg <ingemar.aberg at oracle.com> wrote:
>>
>> Please review this small fix to hotspot's test makefile
>>
>> The file hotspot/test/Makefile provides '-include $(ALT_MAKE)/Makefile' close to the top (before most variables are set).
>> Move that line to after the variables are defined so they are available to the custom makefile.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8074016
>>
>> Webrev: http://cr.openjdk.java.net/~sla/iaberg/8074016/webrev.00/
>>
>> /Ingemar
>



More information about the build-dev mailing list