[9] RFR 8086002: Move apple.security.AppleProvider to a proper module

Sean Mullan sean.mullan at oracle.com
Fri Aug 14 13:30:24 UTC 2015


Couple of minor comments on ProviderConfig.java

183: you can use the diamond operator for anonymous classes now 
(PrivilegedAction<>). You could also use a lambda expression here but 
I'll leave that up to you.

193: the braces around "if (debug != null)" are not indented properly

Looks fine otherwise.

--Sean

On 08/13/2015 10:31 PM, Valerie Peng wrote:
>
> Can someone please help reviewing this change?
> This is to move Apple provider from jdk.deploy.osx module to java.base
> module.
> The native library for Apple provider is separated out from the "osx"
> one generated in jdk.deploy.osx module and named "osxapple" (sort of
> following the convention of SunMSCAPI provider whose native library is
> named "sunmscapi").
>
> webrev: http://cr.openjdk.java.net/~valeriep/8086002/webrev.00/
>
> Thanks,
> Valerie



More information about the build-dev mailing list