Fwd: cygwin too old ?

[Boaz Nahum]

Now it works

Thx
boaz


On Fri, Aug 14, 2015 at 3:52 PM Maurizio Cimadamore <
maurizio.cimadamore at oracle.com> wrote:

> Ok - got it; the original comment that this was fixed in 9 got me off
> track; the code in question is new in Valhalla repo, so there's no JDK 9
> equivalent for it. It's just a bug/glitch in the following hostpot patch:
>
> http://hg.openjdk.java.net/valhalla/valhalla/hotspot/rev/419818b23594
>
> Fixed now.
>
>
> Maurizio
>
>
>
> On 14/08/15 13:27, Boaz Nahum wrote:
>
> YES !!!
>
>
> On Fri, Aug 14, 2015 at 3:08 PM Maurizio Cimadamore <
> maurizio.cimadamore at oracle.com> wrote:
>
>> Is this only an error with Windows build?
>>
>> Maurizio
>>
>> On 14/08/15 12:43, Boaz Nahum wrote:
>> > Thx now I have valhalla on my win 10  :)
>> >
>> > One more little sync request
>> >
>> > src/share/vm/classfile/systemDictionary.cpp
>> >
>> > contains error:
>> >
>> > -  return (strstr(str, str_to_find));
>> >
>> > Should be
>> >
>> > +  return (strstr(str, str_to_find)) != NULL;
>> >
>> > It was fixed on jdk9dev
>> >
>> > Can I asked for this sync too ?
>> >
>> > Boaz
>> >
>> > On Fri, Aug 14, 2015 at 1:53 PM Boaz Nahum <boaznahum at gmail.com> wrote:
>> >
>> >> Yes, it works.
>> >> Thx
>> >> Boaz
>> >>
>> >>
>> >> On Fri, Aug 14, 2015 at 1:19 PM Maurizio Cimadamore <
>> >> maurizio.cimadamore at oracle.com> wrote:
>> >>
>> >>> I've pushed a temp workaround for this; let me know if it works for
>> you.
>> >>>
>> >>> Maurizio
>> >>>
>> >>> On 14/08/15 11:07, Boaz Nahum wrote:
>> >>>> Many thanks
>> >>>>
>> >>>> Whom should I asked to do this sync?
>> >>>>
>> >>>> Boaz
>> >>>>
>> >>>>
>> >>>> On Fri, Aug 14, 2015 at 12:12 PM Ingemar Åberg <
>> >>> ingemar.aberg at oracle.com>
>> >>>> wrote:
>> >>>>
>> >>>>> Hi Boaz,
>> >>>>>
>> >>>>> Your problem looks like JDK-8079087
>> >>>>> <https://bugs.openjdk.java.net/browse/JDK-8079087>, which has been
>> >>> fixed
>> >>>>> in jdk9/dev. Maybe the Valhalla project needs to sync.
>> >>>>>
>> >>>>> /ingo
>> >>>>>
>> >>>>> On 2015-08-14 10:41, Boaz Nahum wrote:
>> >>>>>> Can any one assist ? Please ?
>> >>>>>>
>> >>>>>> ---------- Forwarded message ---------
>> >>>>>> From: Boaz Nahum <boaznahum at gmail.com>
>> >>>>>> Date: Sun, Aug 9, 2015 at 9:12 PM
>> >>>>>> Subject: cygwin too old ?
>> >>>>>> To: build-dev-request at openjdk.java.net <
>> >>>>> build-dev-request at openjdk.java.net>
>> >>>>>> I got this error message when trying to build
>> >>>>>> http://hg.openjdk.java.net/valhalla/valhalla
>> >>>>>>
>> >>>>>> configure: Your cygwin is too old. You are running
>> 2.2.0(0.289/5/3),
>> >>> but
>> >>>>> at
>> >>>>>> least cygwin 1.7 is required. Please upgrade.
>> >>>>>>
>> >>>>>> Please help !
>> >>>>>>
>> >>>>>> Boaz
>> >>>
>>
>>
>