RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

Erik Joelsson erik.joelsson at oracle.com
Tue Dec 22 07:46:07 UTC 2015


Hello Dmitry,

Nice to see this happen!

make/lib/Lib-jdk.hotspot.agent.gmk:
Missing a "/libsaproc" here:
SA_SRC += $(SA_TOPDIR)/share/native 
$(SA_TOPDIR)/$(OPENJDK_TARGET_OS)/native/libsaproc

Otherwise it looks good.

/Erik

On 2015-12-21 22:50, Dmitry Samersoff wrote:
> Everybody,
>
> Please, review the changes:
>
> http://cr.openjdk.java.net/~dsamersoff/JDK-8067194/webrevs.02/
>
> The problem:
>
>    Serviceability agent source should follow source layout
>    convention for modular jdk.
>
> The solution:
>
>    Move SA sources under src/jdk.hotspot.agent
>
>    Move native code under jdk.hotspot.agent/{OS}/native/libsaproc
>
> Problems left:
>    * I'll file a CR for each of problem and fix it later.
>
>    1. Custom gif copy routine left unchanged.
>
>    2. The name of SA under windows left unchanged it's sawindbg.dll
>
>    3. doc, scripts, test directories moved to a new location
>       as is. It's content about to be evaluated.
>
> -Dmitry
>




More information about the build-dev mailing list