RFR(L): JDK-8067194 Restructure hotspot/agent/src to conform the modular source layout

Dmitry Samersoff dmitry.samersoff at oracle.com
Tue Dec 22 15:45:04 UTC 2015


Thank you!


On 2015-12-22 18:39, Jaroslav Bachorik wrote:
> Hi,
> 
> looks good, modulo the problems you are mentioning (docs will need
> update to refer to correct locations; the same might be true for the
> textual output from scripts). I believe the tests are still passing.
> 
> Supposing the remaining problems are covered by CR you can consider this
> reviewed.
> 
> 
> Regards,
> 
> -JB-
> 
> On 21.12.2015 22:50, Dmitry Samersoff wrote:
>> Everybody,
>>
>> Please, review the changes:
>>
>> http://cr.openjdk.java.net/~dsamersoff/JDK-8067194/webrevs.02/
>>
>> The problem:
>>
>>    Serviceability agent source should follow source layout
>>    convention for modular jdk.
>>
>> The solution:
>>
>>    Move SA sources under src/jdk.hotspot.agent
>>
>>    Move native code under jdk.hotspot.agent/{OS}/native/libsaproc
>>
>> Problems left:
>>    * I'll file a CR for each of problem and fix it later.
>>
>>    1. Custom gif copy routine left unchanged.
>>
>>    2. The name of SA under windows left unchanged it's sawindbg.dll
>>
>>    3. doc, scripts, test directories moved to a new location
>>       as is. It's content about to be evaluated.
>>
>> -Dmitry
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.



More information about the build-dev mailing list