RFR: JDK-8072107: New dependency introduced by deploy.dll and awt.dll (msvcp100.dll)

[Magnus Ihse Bursie]

On 2015-02-05 11:54, Erik Joelsson wrote:
> Hello,
>
> Please review this small fix for a big problem. In JDK-8042707, I 
> tired, but apparently failed, to keep the build functioning with 
> VS2010 just like before. The mistake affecting awt.dll was a 
> misspelled variable in flags.m4. I have built with this change and 
> verified that msvcp100.dll is no longer listed as a dependency of 
> awt.dll.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8072107
> Patch inline:
> diff -r 34e490baa2fb common/autoconf/flags.m4
> --- a/common/autoconf/flags.m4  Wed Jan 28 08:14:14 2015 -0800
> +++ b/common/autoconf/flags.m4  Thu Feb 05 11:47:40 2015 +0100
> @@ -572,7 +572,7 @@
>      # avoid bundling msvcpNNN.dll. Doesn't work with newer versions 
> of visual
>      # studio.
>      if test "x$TOOLCHAIN_VERSION" = "x2010"; then
> -      COMMON_CXXFLAGS_JDK="$COMMON_CXXFLAGS_JDK \
> +      COMMON_CCXXFLAGS_JDK="$COMMON_CCXXFLAGS_JDK \
>            -D_STATIC_CPPLIB -D_DISABLE_DEPRECATE_STATIC_CPPLIB"
>      fi
>    fi
>
> /Erik

Looks good to me.

But I think COMMON_CCXXFLAGS_JDK is a bad name. :( While it is arguably 
better than the old CCXXFLAGS_JDK, I think just COMMON_FLAGS_JDK would 
be even better. Not suggesting that you should change that now, though.

/Magnus