Request for guidance on using possible future sets of javac options

[joe darcy]

Hi Erik,

On 2/6/2015 12:03 AM, Erik Joelsson wrote:
> Hello Joe,
>
> The simplest way of accomplishing this currently would be to add lines 
> like this to make/CompileJavaModules.gmk:
>
> java.base_ADD_JAVAC_FLAGS := -Xdoclint:all/protected 
> "-XdoclintPackage:java.*;javax.*"
> java.desktop_ADD_JAVAC_FLAGS := -Xdoclint:all,-missing/protected 
> "-XdoclintPackage:java.*;javax.*"
>
> This assuming those modules are already setup to using -Xlint:all 
> -Werror in make/common/SetupJavacompilers.gmk, which should be true 
> for at least those two.
>
> Is the separator ';' actually a path separator or always semi colon? 
> If so, please use $(PATH_SEP). Also, a line containing a potential 
> semi colon must always be quoted before given to the shell.

That particular idiom didn't seem to work. I also tried

diff -r d91ed1951b94 make/CompileJavaModules.gmk
--- a/make/CompileJavaModules.gmk    Thu Jan 29 15:34:46 2015 -0800
+++ b/make/CompileJavaModules.gmk    Fri Feb 06 14:40:16 2015 -0800
@@ -42,6 +42,7 @@

  ################################################################################

+java.base_JAVAC_WARNINGS += -Xdoclint:all/protected 
"-Xdoclint/package:java.*,javax.*"
  java.base_COPY := .icu .dat .spp content-types.properties 
hijrah-config-islamic-umalqura.properties
  java.base_CLEAN := intrinsic.properties

without effect using an in-progress version of the javac feature. The 
base module has a handful of doclint warnings in it so the compile 
should fail with the amended command line. (The compile fails as expect 
if done stand-alone from the command line.)

Thanks,

-Joe

>
> /Erik
>
> On 2015-02-06 02:19, Joseph D. Darcy wrote:
>> Hello,
>>
>> As a continuation of the warnings effort, I'd like to see doclint 
>> checking selectively enabled during the main build of the Java 
>> sources in the jdk repo by javac.
>>
>> As the name implies, the javac "-Xdoclint" argument enables 
>> structural checking of javadoc comments by javac. For the java.* and 
>> javax.* classes in the jdk repo which go into the Java SE docs 
>> bundle, many of them have already been cleared of doclint warnings; 
>> in awt and swing, about 1500 public or protected declarations are 
>> missing doc comments.
>>
>> Work is underway to provide a package (or module filter) on where 
>> doclint is applied (JDK-8071851:
>> Provide filtering of doclint checking based on packages). Once that 
>> functionality is available, I'd like to compile modules like 
>> java.base with
>>
>>     -Xlint:all -Werror -Xdoclint:all/protected 
>> -XdoclintPackage:java.*;javax.*
>>
>> and modules like java.desktop with
>>
>>     -Xlint:all -Werror -Xdoclint:all,-missing/protected 
>> -XdoclintPackage:java.*;javax.*
>>
>> Is there a suggested way to modify make/common/SetupJavaCompilers.gmk 
>> and other files to most easily accomplish this?
>>
>> Thanks,
>>
>> -Joe
>