[9] Review Request: 8039269 images/cursors should not be in ${java.home}/lib

Mandy Chung mandy.chung at oracle.com
Sat Feb 14 00:18:03 UTC 2015


On 2/13/15 10:01 AM, Sergey Bylokhov wrote:
>      http://cr.openjdk.java.net/~serb/8039269/webrev.00/root
>      http://cr.openjdk.java.net/~serb/8039269/webrev.00/jdk
>
I looked at java/awt/Cursor.java that looks fine to me

Minor comment on java/awt/Cursor.java
    line 166, 167: all caps are usually used for constant variable names.
    But I found there are other final String that starts with Uppercase
    that may be better to be consistent.
    line 440-448: you can convert to try-with-resources

Mandy




More information about the build-dev mailing list