[8u60] RFR: 8043340: [macosx] Fix hard-wired paths to JavaVM.framework

[David Holmes]

On 15/01/2015 6:23 AM, David DeHaven wrote:
>
> Can someone from hotspot-dev please look at the hotspot changes?

Looks okay to me.

Thanks,
David H.

> -DrD-
>
>> Hello,
>>
>> This looks good to me. Thanks for the detailed table!
>>
>> /Erik
>>
>> On 2015-01-14 04:09, David DeHaven wrote:
>>>>> The --with-xcode-path argument is optional, you should also be able to build with Xcode 4 selected via "sudo xcode-select -switch /path/to/Xcode4.app". I leave MAS managed Xcode (currently 6) active as I'm constantly bouncing between projects and it's a hassle to have to remember to reset the active toolchain, so I thought it best to allow configure to be provided a path.
>>>> Ugh. I broke something along the way, this doesn't *quite* work.
>>>>
>>>> xcrun complains with "xcrun: error: missing DEVELOPER_DIR path:"
>>>>
>>>> I think I'm exporting an empty DEVELOPER_DIR. I shall fix and update.
>>> TL;DR: Please review round 2:
>>> http://cr.openjdk.java.net/~ddehaven/8043340/jdk8u/v1/
>>>
>>> (I removed generated-configure.sh to reduce the review size, it will be re-generated prior to pushing)
>>>
>>>
>>> I've tested the following configuration scenarios (output from a shell script I cobbled together..)
>>>
>>> field values:
>>> XC6 - Xcode 6 installed in /Applications/Xcode.app
>>> XC4 - Xcode 4 installed in some other dir
>>> (empty) - Argument not passed to configure
>>>
>>> Result meanings:
>>> DEV_DIR set - configure succeeded, DEVELOPER_DIR was properly exported in spec.gmk
>>> DEV_DIR NOT set - configure succeeded, DEVELOPER_DIR was not needed (XC4 must be selected to achieve this)
>>> Configure failed - Configure properly failed when it detected Xcode > 4
>>>
>>> "Selected" Xcode means version reported by xcode-select -p
>>>
>>>
>>> | Xcode selected | --with-xcode-path | DEVELOPER_DIR     | result           |
>>> -----------------------------------------------------------------------------
>>> | XC4            |                   |                   | DEV_DIR NOT set  |
>>> -----------------------------------------------------------------------------
>>> | XC4            |                   | XC4               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC4            |                   | XC6               | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC4               |                   | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC4               | XC4               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC4               | XC6               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC6               |                   | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC6               | XC4               | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC4            | XC6               | XC6               | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC6            |                   |                   | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC6            |                   | XC4               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC6            |                   | XC6               | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC4               |                   | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC4               | XC4               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC4               | XC6               | DEV_DIR set      |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC6               |                   | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC6               | XC4               | Configure failed |
>>> -----------------------------------------------------------------------------
>>> | XC6            | XC6               | XC6               | Configure failed |
>>> -----------------------------------------------------------------------------
>>>
>>> All the results are as expected. Please note that --with-xcode-path overrides DEVELOPER_DIR, since that could be set in the environment.
>>>
>>> (yeah, I went a little OCD on this...)
>>>
>>> -DrD-
>>>
>>
>