RFR (XS) 8031064: build_vm_def.sh not working correctly for new build cross compile
Dean Long
dean.long at oracle.com
Fri Jan 23 07:29:52 UTC 2015
Done: https://bugs.openjdk.java.net/browse/JDK-8071436
dl
On 1/22/2015 10:45 PM, Dmitry Samersoff wrote:
> Dean,
>
>> Can we make cleaning up the other platforms
>> a separate RFE?
> I think yes. So please file the RFE.
>
> -Dmitry
>
>
> On 2015-01-22 21:01, Dean Long wrote:
>> On 1/22/2015 2:19 AM, David Holmes wrote:
>>> On 22/01/2015 8:39 AM, Dean Long wrote:
>>>> Thanks Dmitry. The updated webrev is here:
>>>>
>>>> http://cr.openjdk.java.net/~dlong/8031064/webrev.3/
>>> This looks weird:
>>>
>>> + VMDEF_PAT = ^_ZTV
>>> + VMDEF_PAT := ^gHotSpotVM|$(VMDEF_PAT)
>>> + VMDEF_PAT := ^UseSharedSpaces$$|$(VMDEF_PAT)
>>> + VMDEF_PAT := ^_ZN9Arguments17SharedArchivePathE$$|$(VMDEF_PAT)
>>>
>>> but I can sort of see why you wanted to do it that way.
>>>
>> Do you have a suggestion for a less-weird-looking way to do it?
>>
>>> I assume you have verified the results are identical?
>>>
>> Yes.
>>
>>> I would be good to see this applied uniformly across all platforms as
>>> well (except windows).
>>>
>> I suppose, but isn't linux the only platform where we might be
>> cross-compiling? I'm not setup to
>> build for aix, bsd, or solaris, and if I build in JPRT, I'm not sure it
>> will save the vm.def or mapfile to
>> make a comparison against. Can we make cleaning up the other platforms
>> a separate RFE?
>>
>> dl
>>
>>> Thanks,
>>> David
>>>
>>>> dl
>>>>
>>>> On 1/21/2015 12:11 AM, Dmitry Samersoff wrote:
>>>>> Dean,
>>>>>
>>>>> vm.make ll. 247
>>>>>
>>>>> 1. *.o should be $(Obj_Files)
>>>>>
>>>>> 2.
>>>>>
>>>>> $(NM) --defined-only *.o | sort -k3 -u |
>>>>> awk '/$(VMDEF_PAT)/{ print "\t" $$3 ";" }'
>>>>>
>>>>> should give you the same result with less efforts
>>>>>
>>>>> -Dmitry
>>>>>
>>>>> On 2015-01-21 07:59, Dean Long wrote:
>>>>>> Here's version 2, which does everything in vm.make and doesn't do
>>>>>> anything that is shell-specific:
>>>>>>
>>>>>> http://cr.openjdk.java.net/~dlong/8031064//webrev.2/
>>>>>>
>>>>>> thanks,
>>>>>>
>>>>>> dl
>
More information about the build-dev
mailing list