RFR: JDK-8055190: Cleanup include and exclude of core-libs native libraries after source code restructure
Erik Joelsson
erik.joelsson at oracle.com
Fri Jan 23 14:59:18 UTC 2015
On 2015-01-23 15:41, Alan Bateman wrote:
> On 23/01/2015 14:35, Erik Joelsson wrote:
>> Hello,
>>
>> Please review this build patch, cleaning up some in the native
>> compilation of some core libraries. After the source code restructure
>> into modules, the need for explicit exclude and include of source
>> files was reduced. This patch moves some OS specific files to OS
>> specific source dirs and adjusts the makefiles. It's based on Magnus'
>> review comments on the source code restructure change.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8055190
>> Webrev: http://cr.openjdk.java.net/~erikj/8055190/webrev.01/
>>
>> /Erik
> This looks a good clean-up and demonstrates the usefulness of the new
> source layout.
>
Thanks
> Can refs.allowed be removed? I thought we removed the JDK 8 dependency
> checker early in JDK 9 so this file shouldn't be needed.
>
I was wondering what it was and could not find any usages. With your
confirmation I have opted to remove it completely instead.
Updated webrev: http://cr.openjdk.java.net/~erikj/8055190/webrev.02/
/Erik
More information about the build-dev
mailing list