RFR: JDK-8071550: SetupJavaComilation EXCLUDE/INCLUDE/EXCLUDE_FILE do not work on META-INF files

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Jan 26 15:04:24 UTC 2015


On 2015-01-26 12:26, Erik Joelsson wrote:
> Hello,
>
> Please review this small fix in JavaCompilation.gmk. 
> SetupJavaComilation EXCLUDE/INCLUDE/EXCLUDE_FILE do not work on 
> META-INF files, unless there is a COPY or COPY_FILES parameter set. 
> The fix is quite simple. Move the filtering of $1_ALL_COPIES outside 
> of the conditional for if $1_COPY or $1_COPY_FILES are set.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8071550
> Webrev: http://cr.openjdk.java.net/~erikj/8071550/webrev.01/
>
> /Erik

Looks good to me.

/Magnus



More information about the build-dev mailing list