RFR: 8081589: Output of -XX:+TraceClassLoadingPreorder in JDK9 incompatible with MakeClasslist tool

[Ioi Lam]

Looks good!

Thanks
- Ioi

On 7/2/15 7:12 AM, Claes Redestad wrote:
> Hi Ioi,
>
> On 2015-07-01 22:44, Ioi Lam wrote:
>> Claes,
>>
>> The changes look good to me. It's nice to replace a large amount of 
>> Java code with a simple script.
>>
>> How about doing the line splitting like this:
>>
>> var classes = readFully(arg).replace(/[\r\n]+/g, "\n").split("\n")
>>
>> That way it will be able to handle an input file that have a mixture 
>> of newline characters (e.g., if someone has edited a Unix text file 
>> on a Windows editor).
>
> Sure thing, this also makes the script more concise:
>
> http://cr.openjdk.java.net/~redestad/8081589/webrev.03/
>
> Thanks!
>
> /Claes
>
>>
>> Thanks
>> - Ioi
>>
>> On 7/1/15 7:54 AM, Claes Redestad wrote:
>>> Hi,
>>>
>>> please review this rewrite/cleanup of the MakeClasslist tool to 
>>> operate on the output of
>>> -XX:DumpLoadedClassList rather than -XX:+TraceClassLoadingPreorder. 
>>> Since the tool
>>> became rather trivial I opted to write it in nashorn-compliant 
>>> javascript to streamline
>>> the usage.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8081589
>>> Webrev: http://cr.openjdk.java.net/~redestad/8081589/webrev.02
>>>
>>> A number of undocumented/unused tests were removed and an outdated 
>>> README was
>>> incorporated into the tool source itself, among other things 
>>> clarifying that the checksum
>>> needs to be calculated and added to the classlist before checking it 
>>> into the workspace.
>>>
>>> I've asked around about how to go about adding tests for standalone 
>>> tools like these, but
>>> didn't come up with a good answer. If someone insists I add a small 
>>> test to this I'd hope
>>> there's some insight into how best to do that (shell-based jtreg test?)
>>>
>>> Thanks!
>>>
>>> /Claes
>>
>