RFR: JDK-8087193: Support building with devkits on Macosx

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Fri Jun 12 13:07:37 UTC 2015


On 2015-06-12 09:05, Erik Joelsson wrote:
> On the machine I'm trying this on, without any C compiler on the path, 
> this is what I get with the patch. Note that "uname -p" is what 
> autoconf-config.guess is using.
>
> > uname -m
> x86_64
> > uname -p
> i386
>
> > bash common/autoconf/build-aux/autoconf-config.guess
> i386-apple-darwin13.4.0
>
> > bash common/autoconf/build-aux/config.guess
> x86_64-apple-darwin13.4.0

Thanks!

I misread the sed expression and couldn't figure out how it could 
possibly work. :)

Looks good to me now.

/Magnus
>
> /Erik
>
> On 2015-06-12 08:52, Magnus Ihse Bursie wrote:
>> On 2015-06-11 15:09, Erik Joelsson wrote:
>>> It seems this approach didn't quite work out. The bootstrapping 
>>> order of configure is sensitive. Here is another attempt at solving 
>>> the issue by simply forcing macosx to be x86_64 in our config.guess 
>>> wrapper.
>>>
>>> http://cr.openjdk.java.net/~erikj/8087193/webrev.02/
>>
>> This code:
>>
>> +echo $OUT | grep i386-apple-darwin > /dev/null 2> /dev/null
>> +if test $? = 0; then
>> +  REAL_CPU=`uname -m`
>> +  OUT=$REAL_CPU`echo $OUT | sed -e 's/[^-]*//'`
>> +fi
>>
>>
>> Can you provide an example of  uname -m and the resulting OUT string 
>> on macosx/x64?
>>
>> /Magnus
>>
>>>
>>> /Erik
>>>
>>> On 2015-06-11 13:14, Erik Joelsson wrote:
>>>> I forgot to motivate the change. Configure runs config.guess to 
>>>> figure out what kind of machine it's running on. That file in turn 
>>>> uses the C preprocessor to figure out if it's 32 or 64 bit. If we 
>>>> don't setup devkit before running config.guess, the preprocessor 
>>>> might not be available and configure will think the mac is a 32 bit 
>>>> machine.
>>>>
>>>> /Erik
>>>>
>>>> On 2015-06-11 12:46, Erik Joelsson wrote:
>>>>> Hello,
>>>>>
>>>>> Please review this minor tweak to configure which enables the use 
>>>>> of a portable devkit on Macosx. Also included is the script used 
>>>>> to generate the devkit. The plan is use this internally on our 
>>>>> build servers to ease installation and setup of our machines.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8087193
>>>>> Webrev: http://cr.openjdk.java.net/~erikj/8087193/webrev.01/
>>>>>
>>>>> /Erik
>>>>
>>>
>>
>




More information about the build-dev mailing list