RFR: JDK-8074690 Fix for JDK-8074429 was not complete

[Magnus Ihse Bursie]

On 2015-03-09 12:50, Alan Bateman wrote:
>
>
> On 09/03/2015 11:46, Magnus Ihse Bursie wrote:
>> The fix for JDK-8074429 
>> <https://bugs.openjdk.java.net/browse/JDK-8074429> moved the jar tool 
>> into a new jdk.jartool module.
>>
>> However, it did not remove all references from the old module. 
>> Gensrc-jdk.dev.gmk still references the old jar path, which is no 
>> longer valid.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8074690
>> Patch inline:
>> diff --git a/make/gensrc/Gensrc-jdk.dev.gmk 
>> b/make/gensrc/Gensrc-jdk.dev.gmk
>> --- a/make/gensrc/Gensrc-jdk.dev.gmk
>> +++ b/make/gensrc/Gensrc-jdk.dev.gmk
>> @@ -32,8 +32,7 @@
>>  $(eval $(call SetupCompileProperties,COMPILE_PROPERTIES, \
>>      $(filter %.properties, \
>>          $(call CacheFind, \
>> - $(JDK_TOPDIR)/src/jdk.dev/share/classes/jdk/tools/jimage/resources \
>> - $(JDK_TOPDIR)/src/jdk.dev/share/classes/sun/tools/jar/resources)), \
>> + 
>> $(JDK_TOPDIR)/src/jdk.dev/share/classes/jdk/tools/jimage/resources)), \
>>      ListResourceBundle))
> This looks okay to me, very easy to leave references when it doesn't 
> cause a warning or failure.
It did leave a warning, though (that's how I noticed it):
/usr/bin/find: 
`/localhome/hg/jdk9-dev-BAR/jdk/src/jdk.dev/share/classes/sun/tools/jar/resources': 
No such file or directory

But as you said, it didn't cause a failure. Maybe we should tighten the 
implementation on CacheFind to catch invalid paths.

/Magnus