RFR: JDK-8075140: Solaris build of native libraries not consistently using EXTRA_CFLAGS and EXTRA_LDFLAGS

Tim Bell tim.bell at oracle.com
Fri Mar 13 15:55:04 UTC 2015


Hello Erik:

> While working on the new Hotspot makefiles in build-infra I noticed 
> this problem. When introducing devkits for Solaris, we rely on the 
> variables EXTRA_CFLAGS, EXTRA_CXXFLAGS and EXTRA_LDFLAGS to propagate 
> the SYSROOT specific flags into the hotspot build. However, these 
> flags aren't consistently used in the Hotspot build for all the native 
> libraries.
>
> This patch adds the variables to all missing compile and link command 
> lines. It also fixes an issue with saproc.so where the debug info was 
> created off one of the object files instead of the library.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8075140
> Webrev: http://cr.openjdk.java.net/~erikj/8075140/webrev.hotspot.01/

Looks good to me.

Tim




More information about the build-dev mailing list