[OpenJDK 2D-Dev] RFR: 8075277 : JDK is still building X11 related Java files on OSX

[Erik Joelsson]

Hello Phil,

A minor style issue. We would appreciate if the java.desktop_EXCLUDES 
followed the same style as java.desktop_EXCLUDE_FILES, with 4 spaces 
indent and a line break at the start and end, like this:

java.desktop_EXCLUDES += \
     sun/awt/X11 \
     sun/java2d/x11 \
     sun/java2d/jules \
     sun/java2d/xr \
     com/sun/java/swing/plaf/gtk \
     #

/Erik


On 2015-03-17 00:05, Phil Race wrote:
> One more update: http://cr.openjdk.java.net/~prr/8075277.2/
>
> just adds sun/awt/motif/* to the exclude list.
>
> I'm deleting that directory in another fix but those without those 
> changes need it
> excluded too
>
> -phil.
>
> On 3/16/15 3:05 PM, Phil Race wrote:
>> There are some files in sun/print some directories still being used 
>> but for the files
>> explicitly listed, then in each case all .java files in those 
>> directories are now unused.
>> So yes, I can make this cleaner and less fragile too!
>>
>> http://cr.openjdk.java.net/~prr/8075277.1/
>>
>> -phil.*
>> *
>> On 3/16/15 2:18 PM, Sergey Bylokhov wrote:
>>> Hi, Phil
>>> Is it possible to replace a long list "java.desktop_EXCLUDE_FILES" 
>>> using $(wildcard, or we still using some files on osx from the unix 
>>> folder?
>>>
>>>>
>>>> Although a more complete fix would do something like refactor the 
>>>> source files,
>>>> as that would be less fragile amongst other things, this at least 
>>>> gets us into a
>>>> better shape with minimal disruption - and solves my immediate 
>>>> problem :-)
>>> There is a CR for this: 
>>> https://bugs.openjdk.java.net/browse/JDK-8075254
>>>> And it is not clear to me why there was an unused reference to
>>>> FontConfigManager in the Mac code. Removing it breaks
>>>> a link that dragged in X11 related code.
>>>>
>>>> I expect the files shipped on OS X to go down as a result of
>>>> removing these 'dead' ones.
>>>> I would also have got rid of the Windows L&F but that needs
>>>> a bit of work on the Swing side first : 
>>>> https://bugs.openjdk.java.net/browse/JDK-8075255
>>>>
>>>> -phil.
>>>>
>>>
>>>
>>> -- 
>>> Best regards, Sergey.
>>
>