[8u-dev] RFR: 8075400: Cannot build hotspot in jdk8u on OSX 10.10 (Yosemite)

[David Holmes]

On 18/03/2015 6:24 PM, Erik Joelsson wrote:
>
> On 2015-03-18 01:35, David Holmes wrote:
>> Hi David
>>
>> On 18/03/2015 8:54 AM, David DeHaven wrote:
>>> Fairly minor build system bug fix on Mac. In short, the
>>> -mmacosx-version-min argument is never being passed to the linker,
>>> where it's actually needed to assert the minimum OS version
>>> requirement in the final Mach-O binary. This was causing ld to fail
>>> when building on 10.10. I've no idea why it's different from 10.9 as
>>> I'm using the exact same copy of Xcode between 10.9 and 10.10 and it
>>> works fine on 10.9. I also had to modify saproc.make to pass that
>>> argument when it builds the SA debugger backend. All changes should
>>> only affect Mac, but kicking off a full JPRT test run to be sure.
>>> Webrev is against jdk8u-dev but will push through hs-dev if/when
>>> approved. This bug impacts 8u only, no backports necessary.
>>>
>>> JBS Issue:
>>> https://bugs.openjdk.java.net/browse/JDK-8075400
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ddehaven/8075400/hotspot.0/
>>
> Looks good to me.
>> + # bring in minimum version argument or we'll fail on OSX 10.10
>> + SA_LFLAGS = $(LFLAGS)
>>
>> LFLAGS or LDFLAGS ??
>>
> The hotspot makefiles in 8u don't seem to use the variable LDFLAGS at
> all, it's called LFLAGS.

Ah! I failed to spot that the change in gcc.make was from LDFLAGS to LFLAGS.

Thanks,
David H.


> /Erik