RFR: JDK-8075725: Remove /jre subdir in hotspot dist dir

[Erik Joelsson]

On 2015-03-24 14:14, Magnus Ihse Bursie wrote:
> On 2015-03-23 14:36, Erik Joelsson wrote:
>> Hello,
>>
>> In JDK 9, the /jre sub directory in the jdk image has been removed. 
>> We should also remove this in the hotspot dist output directory and 
>> the corresponding import logic in the jdk build.
>>
>> There are still references to /jre in hotspot.script and build.sh, 
>> but since I don't know how or if these files are used, I don't dare 
>> changing them.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8075725
>> Webrev: http://cr.openjdk.java.net/~erikj/8075725/webrev.01/
>
> As far as I can tell, it looks good.
>
> Was the reason you renamed EXPORT_JRE_BIN_DIR et al to EXPORT_BIN_DIR 
> to get them to better match the new layout? That also triggered a lot 
> of code changes that would not have been needed otherwise. As I 
> interpret the fix, you only changed the actual path in a few places, 
> and the rest of the changes was just variable renames. If anything, 
> I'd be slightly inclined to think that the variable names, while 
> somewhat misleading, could have stayed, to minimize the impact of the 
> change.
>
The variable names could have stayed yes, but I figured them 
conceptually wrong in the new world without /jre and for that reason 
confusing for future readers of these files.

/Erik