RFR: JDK-8078046 Remove MCS post-processing on Solaris

[Magnus Ihse Bursie]

On 2015-04-17 12:18, David Holmes wrote:
> Hi Magnus,
>
> On 17/04/2015 7:18 PM, Magnus Ihse Bursie wrote:
>> We should remove the MCS post-processing on Solaris.
>>
>> The msc command is used to post-process the binaries on Solaris, with
>> the intent of adding the version number. Post-processing of binaries is
>> a step that we'd like to avoid, if possible.
>>
>> It now turns out that the MCS processing has been broken since at least
>> JDK8, and nobody has noticed. I recommend we just remove it.
>
> In what way was it broken?
>
> What role was it serving?
>
> Who was the consumer of the added information?
>
> Are the people who can answer those questions likely to be watching 
> build-dev? ;-)
>
> Happy to see code removed and the build simplified, but only after 
> ensuring we understand the impact.

Hi David,

I have now conducted some research internally in Oracle. It seems noone 
here knows why this was added. The only reply I got was that the 
information in the .comment section on Solaris binaries are useful for 
sysadmins to determine e.g. what patch level of the OS was used when 
compiling the binary.

Unfortunately, we strip that information away with the "-d" flag. :-(

So I believe the patch is safe, and will indeed improve the usefulness 
of the Solaris binaries.

Are you ok with this reply, and hence the patch?

/Magnus


>
> Thanks,
> David
>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8078046
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8078046-remove-MCS/webrev.01
>>
>> /Magnus