RFR: JDK-8141444 Clean up building of JDK launchers

[Magnus Ihse Bursie]

On 2015-11-05 09:19, Alan Bateman wrote:
>
>
> On 05/11/2015 07:27, Magnus Ihse Bursie wrote:
>> The JDK launchers have been built by a macro which is using 
>> positional arguments instead of named argument. This needs to be 
>> fixed to be able to properly track what is happening.
>>
>> Some additional TLC for launchers is also needed.
>>
>> To verify the fix, I've used the new COMPARE_BUILD feature.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141444
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8141444-clean-up-launchers/webrev.01
> I think that when we bring this into the jigsaw/jake forest that we 
> might need want to consider renaming MAIN_CLASS because the value 
> changes from a class name to a module name + class name.

If you need to do jigsaw changes, sure, just do what's needed. However, 
it sounds like you still need a main class, but in addition you also 
need a module. If that's the case, it seems that you could keep the 
MAIN_CLASS and just add a MODULE. In fact, I believe the the module the 
launcher belongs to should be available as $(MODULE), so it can probably 
be picked up automatically by SetupBuildLauncher.

/Magnus