RFR: JDK-8141543 Propagate --disable-warnings-as-errors to hotspot

[Volker Simonis]

Hi Magnus,

great that finally somebody is addressing this issue!

But shouldn't we also change the lines:

WARNINGS_ARE_ERRORS = -Werror

to:

WARNINGS_ARE_ERRORS ?= -Werror

in the various hotspot compiler files (e.g. make/linux/makefiles/gcc.make).

Maybe I'm missing something, or do you plan to do that as a follow up
change in the hotspot repo?

Otherwise looks good.

Thank you and best regards,
Volker


On Thu, Nov 5, 2015 at 4:43 PM, Magnus Ihse Bursie
<magnus.ihse.bursie at oracle.com> wrote:
> Unfortunately, the --disable-warnings-as-errors flag only operates on the
> build-infra code, and does not propagate to the Hotspot build system.
>
> This is unfortunate, and also very confusing for users who think they have
> disabled warnings as errors, only to get an error in the hotspot build
> instead.
>
> We should set the correct value for hotspot makefiles from configure as
> well.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8141543
> WebRev:
> http://cr.openjdk.java.net/~ihse/JDK-8141543-propagate-disable-warnings-as-errors-to-hotspot/webrev.01
>
> /Magnus