RFR (XXXS) - 8080940 Remove mcs post-hook from hotspot solaris builds

David Holmes david.holmes at oracle.com
Tue Nov 10 05:04:54 UTC 2015


Hi Ioi,

Based on Magnus's findings as described in the bug this removal seems 
fine to me.

David

On 10/11/2015 12:56 PM, Ioi Lam wrote:
> Please review a very very small fix:
>
> http://cr.openjdk.java.net/~iklam/8080940-remove-solaris-mcs/
>
> Bug: 8080940 Remove mcs post-hook from hotspot solaris builds
>
> https://bugs.openjdk.java.net/browse/JDK-8080940
>
> Summary of fix:
>
>      I am getting a heart attack every time I look at the
>      Solaris build log and it tells me libjvm.so has failed
>      when it hasn't. So here's a patch.
>
>      The call to mcs has been removed from LINK_LIB.CXX/POST_HOOK
>
>      According to Magnus's analysis in the bug report, the removal does
> not cause any issue.
>
>      I verified the word "mcs" no longer appear in the SPARC build logs,
>      and there's no more spurious report of libjvm.so failure.
>
> Tests:
>
>      JPRT with all solaris targets.:
>      Build Stats:   5 pass, 0 fail, 0 killed, 0 working, 0 initializing,
> 0 not started
>      Test Stats:   57 pass, 0 fail, 0 killed, 0 working, 0 initializing,
> 0 not started
>
>
> Thanks
> - Ioi



More information about the build-dev mailing list