RFR: JDK-8141696 Improve COMPARE_BUILD

[Magnus Ihse Bursie]

On 2015-11-10 09:52, Erik Joelsson wrote:
>
>
> On 2015-11-09 11:09, Magnus Ihse Bursie wrote:
>> The new COMPARE_BUILD feature has proven valuable to build system 
>> development. However, after use it leaves the build system in a 
>> different state than prior to use, which requires manual intervention 
>> for multiple runs.
>>
>> This patch fixes so that the build system is restored to the starting 
>> point (except for unhandled crashes, e.g. in configure). It also 
>> moves some error handling logic to InitSupport.gmk so it does not 
>> clutter Init.gmk.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8141696
>> WebRev: 
>> http://cr.openjdk.java.net/~ihse/JDK-8141696-improve-COMPARE_BUILD/webrev.01
>>
>> /Magnus
> +        # If running with a COMPARE_BUILD patch, reverse-apply it
> +        $(if $(COMPARE_BUILD_PATCH), $(PATCH) -p1 < 
> $(COMPARE_BUILD_PATCH))
>
> That doesn't look like reverse applying the patch. Shouldn't there be 
> an -R switch to patch?

There should indeed. Thank you, mr Eagle Eye.

(There was one before I migrated the logic into InitSupport. I think I 
heard the *thump* when it dropped on the floor. :-/)

WebRev: 
http://cr.openjdk.java.net/~ihse/JDK-8141696-improve-COMPARE_BUILD/webrev.02

/Magnus