RFR (S): JDK-8142909 Integration of minor fixes from the build-infra project

Erik Joelsson erik.joelsson at oracle.com
Fri Nov 13 16:42:30 UTC 2015


Looks good!

/Erik

On 2015-11-13 12:33, Magnus Ihse Bursie wrote:
> On 2015-11-13 09:13, Erik Joelsson wrote:
>> Hello,
>>
>> make/bsd/makefiles/amd64.make:
>> make/bsd/makefiles/gcc.make:
>> Perhaps the order of "$(OPT_CFLAGS/NOOPT) $(OPT_CFLAGS/$(BUILDARCH))" 
>> should be reversed to guarantee that NOOPT is the one used in case 
>> BUILDARCH contains something that conflicts? The solaris file does it 
>> this way.
> You know you wrote that code originally? ;-)
>
> Yeah, I agree, it's more reasonable. Updated webrev:
> http://cr.openjdk.java.net/~ihse/JDK-8142909-hotspot-build-infra-integration/webrev.02
>
> /Magnus
>
>>
>> Otherwise looks good.
>>
>> /Erik
>>
>> On 2015-11-13 03:34, Magnus Ihse Bursie wrote:
>>> In the new hotspot build project, we have made a few changes to the 
>>> existing build. In preparation for the new build, I'd like to 
>>> integrate these into mainline.
>>>
>>> These changes are:
>>> * When overriding optimization, do not lose current debug (-g) 
>>> setting (!)
>>> * Make adlc actually quiet in quiet mode
>>> * Make g1EvacStats.cpp compile in all cases without precompiled headers
>>> * Sort saproc object files when linking (facilitates comparison to 
>>> new build)
>>>
>>> Unless someone suggests otherwise, I intend to push this (using 
>>> JPRT) to hs-rt.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8142909
>>> WebRev: 
>>> http://cr.openjdk.java.net/~ihse/JDK-8142909-hotspot-build-infra-integration/webrev.01
>>>
>>> /Magnus
>>
>




More information about the build-dev mailing list