RFR: JDK-8036003: Add --with-debug-symbols=[none|internal|external|zipped]

[Andrew Hughes]

----- Original Message -----
> * Yasumasa Suenaga <yasuenag at gmail.com> [2015-11-16 04:38]:
> > I would like to propose JDK-8036003: Add
> > --with-debug-symbols=[none|internal|external|zipped] .
> > 
> > I had posted this enhancement which provides new make variable [1].
> > But it does not fit current jdk 9. So I propose it again as new configure
> > option.
> >
> > I'm sure that this enhancement helps Linux distros to package OpenJDK.
> > For example, if you create RPM package of OpenJDK, you have to pass many
> > make variables [2].
> 
> A big +1 on having this. It would make the life of those of us packaging
> this for linux distributions quite a bit easier if this was officially
> supported upstream.
> 
> > Could you review it?
> >   http://cr.openjdk.java.net/~ysuenaga/JDK-8036003/webrev.00/
> 
> I am a bit unsure about the interaction of --enable-debug-symols and
> --with-debug-symbols. Setting ENABLE_DEBUG_SYMBOLS to 'false' for
> 'internal' seems a bit surprising. Could you clarify why leaving
> ENABLE_DEBUG_SYMOLS to true is a bad idea?

As I mentioned in my response [0], ENABLE_DEBUG_SYMBOLS is rather
badly named, as it seems to refer to not only building with debugging
information, but also splitting it out into separate files. I remember
when we discussed this on the HotSpot list that ENABLE_DEBUG_SYMBOLS=false
was suggested. The use of DEBUG_BINARIES will ensure that -g is passed.

Unless things have changed (and this webrev makes me suspect not), a
more accurate name would be ENABLE_EXTERNAL_DEBUG_SYMBOLS.

I'm aware that this is papering over a mess below it, mostly in the HotSpot
build, but the lack of movement there makes this seem like the only option.

> 
> Thanks,
> Omair
> 
> --
> PGP Key: 66484681 (http://pgp.mit.edu/)
> Fingerprint = F072 555B 0A17 3957 4E95  0056 F286 F14F 6648 4681
> 

-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

PGP Key: rsa4096/248BDC07 (hkp://keys.gnupg.net)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07