RFR 8043138: Attach API should not require jvmstat rmi protocol

Staffan Larsen staffan.larsen at oracle.com
Wed Nov 25 08:11:57 UTC 2015


> On 24 nov. 2015, at 17:03, Jaroslav Bachorik <jaroslav.bachorik at oracle.com> wrote:
> 
> Please, review the following change
> 
> Issue : https://bugs.openjdk.java.net/browse/JDK-8043138
> Webrevs:
> * top level: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/top
> * jdk: http://cr.openjdk.java.net/~jbachorik/8043138/webrev.00/jdk
> 
> This patch splits up the jdk.jvmstat module to jdk.jvmstat and jdk.jvmstat.rmi to make the basic jvmstat functionality available without requiring dependencies on RMI.
> 
> The split is pretty straightforward - all the RMI dependent implementation is moved to the new module as well as 'jstatd' implementation.
> 
> The change requires changes in the makefile (for merging META-INF/services resources from jdk.jvmstat and jdk.jvmstat.rmi) and therefore I am posting this request also to the build-dev mailing list.

Can you explain what the makefile is doing? Why do we need to merge these files?

> 
> 
> Thanks,
> 
> -JB-




More information about the build-dev mailing list