RFR: 8139272: Add configure variable to set concurrency for jtreg tests

[Magnus Ihse Bursie]

On 2015-10-20 16:05, Erik Helin wrote:
> On 2015-10-14, Magnus Ihse Bursie wrote:
>> On 2015-10-09 14:09, Erik Helin wrote:
>>> Hi all,
>>>
>>> this patch adds a new configure variable: --with-test-jobs. The new
>>> variable configures how many tests jobs we run concurrently (aka the
>>> -concurrency flag to JTReg). Today --with-jobs is passed as the
>>> -concurrency flag to JTReg which most likely is too big for most
>>> systems with many cores.
>>>
>>> For hotspot, the only "supported" configuration for running the jtreg
>>> tests is with -concurrency:1. However, most machines will run the tests
>>> successfully with more concurrency, but I used a default of 1. For the JDK
>>> tests I kept --with-jobs as the default concurrency since I want to keep
>>> the old behaviour.
>>>
>>> Enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8139272
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~ehelin/8139272/webrev.00/
>> Hi Erik,
>>
>> Your patch looks basically sound.
> Thanks for reviewing!
>
>> A few comments:
>>
>> * It would be good if you could add a comment somewhere, perhaps in the new
>> function in build-performance.m4, that "0" test jobs means "let the test
>> system use the default".
> Fixed.
>
>> * You should add TEST_JOBS to the list of INIT_CONTROL_VARIABLES in
>> InitSupport.gmk, to stop make from complaining on it.
> Fixed.
>
>> * Also, it would be great if you updated the help message in Help.gmk to
>> include TEST_JOBS.
> Fixed.
>
> Please see new webrevs:
> - Incremental:
>    http://cr.openjdk.java.net/~ehelin/8139272/webrev.00-01/
> - Full:
>    http://cr.openjdk.java.net/~ehelin/8139272/webrev.01/
>
> Thanks,
> Erik
Hi Erik,

Sorry for the delay in responding to this. Your fix looks good to me now!

/Magnus

>
>> /Magnus