[8u] RFR: JDK-8139813: Base heap size on type of boot jdk, not architecture of build machine

[Magnus Ihse Bursie]

On 2015-10-20 10:20, Erik Joelsson wrote:
> Hello,
>
> New webrevs implementing the suggestion by Magnus.
>
> Webrev JDK 9: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk9.02/
> Webrev JDK 8u: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk8u.02/
Looks good. This version was even better than I imagined it would be. 
Thanks!

/Magnus

>
> /Erik
>
> On 2015-10-20 08:51, Magnus Ihse Bursie wrote:
>> On 2015-10-19 13:54, Erik Joelsson wrote:
>>> Hello,
>>>
>>> Please review this minor configure fix. The logic in configure for 
>>> setting up proper mx flags for the bootjdk is flawed in that it 
>>> assumes a 64bit bootjdk if the build machine is 64bit. This patch 
>>> fixes this by instead testing if the bootjdk is 64bit or not. The 
>>> problem was discovered in 8u and is causing trouble for certain 
>>> build setups there. Since it also applies to 9, I'm posting a webrev 
>>> for each, intending to fix this in both releases.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8139813
>>> Webrev JDK 9: http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk9.01/
>>> Webrev JDK 8u: 
>>> http://cr.openjdk.java.net/~erikj/8139813/webrev.jdk8u.01/
>>
>> The code seems correct. A suggestion, though: If you break out the 
>> 64-bit detection and wrap it in a MSG_CHECKING/RESULT pair, we can 
>> get a configure log result that indicates what kind of bootjdk we 
>> think we found. And it will be easier to do a 64-bit check elsewhere, 
>> should the need arise.
>>
>> /Magnus
>