RFR: 8140396 - BUILD_LIBJIMAGE missing as a dependency to JAVA_BASE_EXPORT_SYMBOLS_SRC

Erik Joelsson erik.joelsson at oracle.com
Wed Oct 28 12:43:48 UTC 2015


Looks good to me.

/Erik

On 2015-10-28 13:31, Bob Vandette wrote:
> Please review this 1 line change to add a missing library dependency from
> the recent addition of static build support.  The new libjimage support
> was brought into my forest during the merge before I pushed this feature and
> I missed this dependency. Thanks to Magnus for catching this.
>
> https://bugs.openjdk.java.net/browse/JDK-8140396 <https://bugs.openjdk.java.net/browse/JDK-8140396>
>
>
> diff --git a/make/lib/Lib-java.base.gmk b/make/lib/Lib-java.base.gmk
> --- a/make/lib/Lib-java.base.gmk
> +++ b/make/lib/Lib-java.base.gmk
> @@ -54,7 +54,8 @@
>
>    # The individual symbol files is generated when the respective lib is built
>    $(JAVA_BASE_EXPORT_SYMBOLS_SRC): $(BUILD_LIBJLI) $(BUILD_LIBJAVA) \
> -      $(BUILD_LIBNET) $(BUILD_LIBNIO) $(BUILD_LIBVERIFY) $(BUILD_LIBZIP)
> +      $(BUILD_LIBNET) $(BUILD_LIBNIO) $(BUILD_LIBVERIFY) $(BUILD_LIBZIP) \
> +      $(BUILD_LIBJIMAGE)
>
>    TARGETS += $(JAVA_BASE_EXPORT_SYMBOL_FILE)
> endif




More information about the build-dev mailing list