RFR: JDK-8140591: Add configure argument specifying make executable in JPRT

Tim Bell tim.bell at oracle.com
Thu Oct 29 15:42:49 UTC 2015


Erik:

Looks good to me as well.

Tim

On 10/28/15 04:09, Magnus Ihse Bursie wrote:
> Looks good to me.
>
> Nice solution in basics.m4!
>
> /Magnus
>
>> 28 okt. 2015 kl. 10:47 skrev Erik Joelsson <erik.joelsson at oracle.com>:
>>
>> I've noticed that on some linux systems (maybe even all OEL6 and 7), there is a /usr/bin/gmake binary. Configure unfortunately picks up this gmake instead of the make binary we explicitly put first in the path. I've fixed this by adding a configure parameter in make/jprt.properties in the jdk9 source.
>>
>> We have reports of make crashing in certain situations and I believe using gnu make 4.0 in JPRT, as has been intended, will fix this problem.
>>
>> In addition to this, I also fixed some issues with setting MAKE= on the configure command line. Configure complains that it doesn't recognize MAKE as a valid parameter. It was also not possible to set just an executable name, just an absolute path. I fixed this by rewriting the make detection to use the BASIC_SETUP_TOOL macro which already implements all of this properly.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8140591
>> Webrev: http://cr.openjdk.java.net/~erikj/8140591/webrev.01/
>>
>> /Erik




More information about the build-dev mailing list