RfR JDK-8134453, JAWS crashes in WindowsAccessBridge.DLL on 32 bit 8u60 running on 32 bit Win 7

[Erik Joelsson]

Looks good, thanks.

/Erik

On 2015-09-03 06:46, Tim Bell wrote:
> Hi Pete-
>
> Looks good to me.
>
> Tim
>
>
> On 09/02/15 18:51, Pete Brunet wrote:
>> Thanks Erik, The new webrev is at
>> http://cr.openjdk.java.net/~ptbrunet/JDK-8134453/webrev.01/
>>
>> Do you (and Tim) approve?
>>
>> Pete
>>
>> On 9/2/15 2:38 AM, Erik Joelsson wrote:
>>> Hello Pete,
>>>
>>> While this may work, I would not like to rely on case insensitivity in
>>> the directory name for the headers. I would like that you also change
>>> legacy->LEGACY in CompileJavaClasses.gmk where the headers are 
>>> generated.
>>>
>>> /Erik
>>>
>>> On 2015-09-02 04:02, Pete Brunet wrote:
>>>> Hi I need two reviewers for
>>>> http://cr.openjdk.java.net/~ptbrunet/JDK-8134453/webrev.00/
>>>>
>>>> This problem started in 8u60 b20 and is due to JDK-8078649 which is a
>>>> backport of JDK-8043160. In this fix the text "LEGACY" in file
>>>> jdk/make/lib/PlatformLibraries.gmk was changed to "legacy". The lower
>>>> case legacy is used in a -D compiler flag and as a result doesn't
>>>> activate lines like this in the source code:
>>>>
>>>> #ifdef ACCESSBRIDGE_ARCH_LEGACY
>>>>
>>>> This causes problems with 32 bit builds for 32 bit Win.
>>>>
>>>> I tested the fix by doing a 32 bit Win build and then installing and
>>>> testing that build on a 32 bit Win 7 VM.
>>>>
>>>> Pete
>>>>
>