[8u] Request for Approval and Review: JDK-8136691: 8u65/8u66 b14 Solaris builds failed on Linking libverify.so

[Erik Joelsson]

Thanks Tim,

Since this is Hotspot I assume I need another reviewer. Any chance I 
could get one?

/Erik

On 2015-09-18 11:16, Tim Bell wrote:
> Erik-
>
> The code review part looks good.
>
> Tim
>
> On 09/18/15 09:59, Seán Coffey wrote:
>> Approved but subject to review. Please add the noreg-build label. Add 
>> the 9-na label if it's not applicable to JDK 9. If it is applicable 
>> to JDK 9, create a backport record so that it doesn't get overlooked.
>>
>> Regards,
>> Sean.
>>
>> On 18/09/15 17:41, Erik Joelsson wrote:
>>> Hello,
>>>
>>> Please approve and review this fix for 8u. There is a discrepancy 
>>> between the Solaris and Linux makefiles for Hotspot, where a source 
>>> file is excluded for a certain configuration on Linux but not on 
>>> Solaris. This causes the build to fail on Solaris in that 
>>> configuration.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8136691
>>> Patch:
>>> diff --git a/make/solaris/makefiles/trace.make 
>>> b/make/solaris/makefiles/trace.make
>>> --- a/make/solaris/makefiles/trace.make
>>> +++ b/make/solaris/makefiles/trace.make
>>> @@ -56,8 +56,12 @@
>>>  ifeq ($(HAS_ALT_SRC), true)
>>>  TraceGeneratedNames +=  \
>>>         traceRequestables.hpp \
>>> -    traceEventControl.hpp \
>>> -    traceProducer.cpp
>>> +    traceEventControl.hpp
>>> +
>>> +ifneq ($(INCLUDE_TRACE), false)
>>> +  TraceGeneratedNames += traceProducer.cpp
>>> +endif
>>> +
>>>  endif
>>>
>>>  TraceGeneratedFiles = $(TraceGeneratedNames:%=$(TraceOutDir)/%)
>>>
>>>
>>> /Erik
>>
>