Provide zipped javadoc archive from make

Mario Torre neugens at redhat.com
Wed Apr 13 14:16:05 UTC 2016


On Thu, Apr 7, 2016 at 3:13 PM, Jiri Vanek <jvanek at redhat.com> wrote:
> On 04/07/2016 03:01 PM, Erik Joelsson wrote:
>>
>>
>>
>> On 2016-04-07 14:48, Jiri Vanek wrote:
>>>>
>>>> Hello,
>>>>
>>>> For the JDK 9 change, beware that we are going to be making new bundle
>>>> targets for all kinds of
>>>> bundles. I'm hoping to start that work soon. It might mean a
>>>> reimplementation of this patch, not
>>>> sure yet. Your docs bundle is quite different from the bundle we need so
>>>> we likely need to produce
>>>> both. I might need to rewrite the whole old messy Javadoc.gmk while at
>>>> it, will see.
>>>
>>>
>>>
>>> Sure! Do as as you feel right with this patch. Apply it before or after
>>> refactoring or command me
>>> any way you wish.
>>>
>>>>
>>>> In 9, instead of echo, please use $(call LogInfo, ). No need for quotes
>>>> in that case.
>>>>
>>> sure. done. Now it dont print to stdout, but I guess its purpose.
>>
>> It does if you build with LOG=info.
>
>
> I see. Thanx!
>>>
>>>
>>>> I just now noticed the trailing ';' on lines that do not end with
>>>> backslash.  Please remove those.
>>>> That goes for the 8u patch too if they are present there.
>>>
>>>
>>> Sure. Done too. Just wondering, why?
>>>
>> It's just not the style we use. We try to keep a uniform style in all the
>> makefiles.
>
>
> I thought so, Fair enough:) And thank you!
>>>
>>> https://jvanek.fedorapeople.org/oracle/jdk9/webrevs/zip-docs/v2/
>>>
>> This patch looks good enough for now. You can push it if you like.
>
>
> My patches to OpenJDK are very sparse, so I don't have commit access.  If
> you are willing to push on my behalf, I will be very happy.
>
>
> Thank yo very much fr reviews!

Hi Jiri, Erik,

I just noticed that one. If it's ok I'll push that for you, it's good
to relieve some work out of Oracle's hands when possible.

Cheers,
Mario



More information about the build-dev mailing list