RFR [9] 8044773: Refactor jdk.net API so that it can be moved out of the base module

Mandy Chung mandy.chung at oracle.com
Wed Apr 27 18:24:15 UTC 2016


> On Apr 27, 2016, at 11:16 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> 
> 
> On 27 Apr 2016, at 17:27, Mandy Chung <mandy.chung at oracle.com> wrote:
> 
>> 
>>> On Apr 27, 2016, at 2:04 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
>>> 
>>> This works out quite nice.  Webrev updated in-place:
>>> http://cr.openjdk.java.net/~chegar/8044773/jdk/
>> 
>> One comment on the qualified exports of sun.security.action.GetPropertyAction to jdk.net module.  This is a simple utility method used only in a couple places in jdk.net.  I would suggest to change to usage to call System::getProperty with doPrivileged and no need to add the qualified export from java.base.  
> 
> Agreed. Removed. Webrev updated in-place:
>  http://cr.openjdk.java.net/~chegar/8044773/jdk/

+1

Mandy




More information about the build-dev mailing list