kulla fails to configure with Java 9 ea (Early Access)

[ShinyaYoshida]

Hi Samuel,
That repository is already merged to jdk9/dev:
http://hg.openjdk.java.net/jdk9/dev/

Please use this repository and check that the error is still exist and your
patch works well in jdk9/dev.

Regards,
shinyafox(Shinya Yoshida)


2016-07-30 19:17 GMT+09:00 Samuel Marks <samuelmarks at gmail.com>:

> Hmm, I could only find the one branch:
> http://hg.openjdk.java.net/kulla/dev/branches
>
> This is the file I edited:
> http://hg.openjdk.java.net/kulla/dev/file/77a1e3986f77/common/autoconf/boot-jdk.m4
>
>
> Samuel Marks
> http://linkedin.com/in/samuelmarks
>
> On Fri, Jul 29, 2016 at 6:12 PM, ShinyaYoshida <bitterfoxc at gmail.com>
> wrote:
>
>> Hi Samuel, thank you for resending.
>>
>> Oops, let me confirm one thing please.
>> You got this error on a repository hosted on kulla-dev, right?
>>
>> If so, unfortunately it isn't under maintaining because it already merged
>> to jdk9-dev.
>> Please confirm that you still get this error on jdk9-dev and your patch
>> works well on it.
>>
>> Regards,
>> shinyafox(Shinya Yoshida)
>>
>> 2016/07/29 午後4:55 "Samuel Marks" <samuelmarks at gmail.com>:
>>
>> Error:
>>> configure: Found potential Boot JDK using configure arguments
>>> configure: Potential Boot JDK found at /opt/Java/jdk-9 is incorrect JDK
>>> version (java version "9-ea"); ignoring
>>> configure: (Your Boot JDK must be version 8 or 9)
>>> configure: error: The path given by --with-boot-jdk does not contain a
>>> valid Boot JDK
>>>
>>> Here's a fix to the kulla repository (also attached, not sure what the
>>> protocol is):
>>>
>>> # HG changeset patch
>>> # User Samuel Marks <samuelmarks at gmail.com>
>>> # Date 1469777474 -36000
>>> #      Fri Jul 29 17:31:14 2016 +1000
>>> # Node ID 9268348574206a8487901c8e8a1ea15987709521
>>> # Parent  77a1e3986f77f6e9d1037f4de8296d927ef12ac4
>>> New version check routine to handle Java 9 Early Access release
>>>
>>> diff -r 77a1e3986f77 -r 926834857420 common/autoconf/boot-jdk.m4
>>> --- a/common/autoconf/boot-jdk.m4    Sat Aug 22 00:47:29 2015 -0700
>>> +++ b/common/autoconf/boot-jdk.m4    Fri Jul 29 17:31:14 2016 +1000
>>> @@ -74,11 +74,12 @@
>>>            BOOT_JDK_FOUND=no
>>>          else
>>>            # Oh, this is looking good! We probably have found a proper
>>> JDK.
>>> Is it the correct version?
>>> -          BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | head
>>> -n 1`
>>> +          BOOT_JDK_VERSION=`"$BOOT_JDK/bin/java" -version 2>&1 | awk
>>> '/version/{print $NF}'`
>>> +          BOOT_JDK_VERSION="${BOOT_JDK_VERSION:1:3}"
>>> +          CORRECT_VERSIONS=(1.8 1.9 9 9-e)
>>>
>>>            # Extra M4 quote needed to protect [] in grep expression.
>>> -          [FOUND_CORRECT_VERSION=`echo $BOOT_JDK_VERSION | grep
>>> '\"1\.[89]\.'`]
>>> -          if test "x$FOUND_CORRECT_VERSION" = x; then
>>> +          if [[ ! " ${CORRECT_VERSIONS[*]} " == *" $BOOT_JDK_VERSION "*
>>> ]]; then
>>>              AC_MSG_NOTICE([Potential Boot JDK found at $BOOT_JDK is
>>> incorrect JDK version ($BOOT_JDK_VERSION); ignoring])
>>>              AC_MSG_NOTICE([(Your Boot JDK must be version 8 or 9)])
>>>              BOOT_JDK_FOUND=no
>>>
>>> Samuel Marks
>>> http://linkedin.com/in/samuelmarks
>>>
>>> BTW: I posted in kulla-dev but they told me to post here -
>>> http://mail.openjdk.java.net/pipermail/kulla-dev/2016-July/001508.html
>>>
>>
>