RFR: 8039305: [javadoc] broken link in jdk/api/javadoc/taglet/com/sun/tools/doclets/Taglet.html
Erik Joelsson
erik.joelsson at oracle.com
Wed Aug 3 07:14:03 UTC 2016
The build changes look good to me now.
I can't comment on the implications for the generated docs. Any idea of
why these particular docs were generated in such a special way?
/Erik
On 2016-08-02 22:25, Kumar Srinivasan wrote:
> Hello Erik,
>
> Ok I fixed the items you pointed out, also in my last email, the JIRA
> reference was incorrect, the correct JIRA should be:
> https://bugs.openjdk.java.net/browse/JDK-8039305
>
> The modified webrev is at:
> http://cr.openjdk.java.net/~ksrini/8039305/webrev.01/
>
> Thanks
> Kumar
>
>> Hello Kumar,
>>
>> Some notes:
>>
>> 577: Not sure I agree with repeating the definition of OLD_DOCLET_DIR.
>>
>> 580-587: All these new variables are defined but never used. If you
>> intend to use these values, you also need to add them somewhere in
>> 610-620.
>>
>> /Erik
>>
>> On 2016-08-01 23:56, Kumar Srinivasan wrote:
>>> Hello,
>>>
>>> Please review:
>>> http://cr.openjdk.java.net/~ksrini/8039305/webrev.00/
>>>
>>> Fix for:
>>> https://bugs.openjdk.java.net/browse/JDK-8159305
>>>
>>> This was reported as a broken link, but the fix is to make
>>> the Taglet API bundle "whole", in that, keep all the supporting
>>> files needed by the API bundle, and not delete most of them.
>>>
>>> It is not clear whether this should be fixed now or subsumed
>>> by a future API doc images cleanup effort ?
>>>
>>> Please let me know.
>>>
>>> Thanks
>>> Kumar
>>>
>>>
>>
>
More information about the build-dev
mailing list